Migrate Sell > Catalog > Catalog price rule create/edit action #13716

zuk3975 · 2019-05-08T15:27:17Z

Questions	Answers
Branch?	develop
Description?	Migrate Sell > Catalog > Catalog price rule create/edit action. Condition groups should go to separate PR.
Type?	refacto
Category?	BO
BC breaks?	no
Deprecations?	no
Fixed ticket?	part of #10548
How to test?	use `/admin-dev/index.php/sell/catalog/catalog-price-rules` link to reach migrated catalog price rules list. Click edit or create new to see the form. The Condition groups (at the bottom of the page) are not migrated yet and should be done in separate PR.

This change is

PierreRambaud · 2019-05-13T08:42:41Z

src/Core/Form/IdentifiableObject/DataProvider/CatalogPriceRuleFormDataProvider.php

@@ -58,8 +58,11 @@ public function getData($catalogPriceRuleId)
        $editableCatalogPriceRule = $this->bus->handle(new GetCatalogPriceRuleForEditing((int) $catalogPriceRuleId));

        $price = $editableCatalogPriceRule->getPrice();
+        $leaveInitialPrice = false;
+
        if (-1.0 === $price) {


Watch out with float comparaison in PHP.

admin-dev/themes/new-theme/js/app/utils/datepicker.js

sarjon · 2019-05-15T08:29:51Z

admin-dev/themes/new-theme/js/pages/catalog-price-rule/form/price-field-availability-handler.js

+   */
+  _handle() {
+    const checkboxVal = $(`${this.$checkboxSelector}:checked`).val();
+    const isFieldEnabled = parseInt(checkboxVal, 10);


What's 10?

sarjon · 2019-05-15T08:33:01Z

src/Adapter/CatalogPriceRule/CommandHandler/AddCatalogPriceRuleHandler.php

+        $specificPriceRule->from_quantity = $command->getFromQuantity();
+        $specificPriceRule->price = $command->getPrice();
+        $specificPriceRule->from = $command->getFrom();
+        $specificPriceRule->to = $command->getTo();


I think that getFrom() and getTo() should have better naming. Maybe getDateFrom() or similar, wdyt?

sarjon · 2019-05-15T08:33:27Z

src/Adapter/CatalogPriceRule/CommandHandler/AddCatalogPriceRuleHandler.php

+        $specificPriceRule->to = $command->getTo();
+        $specificPriceRule->reduction_type = $command->getReductionType();
+        $specificPriceRule->reduction_tax = $command->isTaxIncluded();
+        $specificPriceRule->reduction = $command->getReduction();


Maybe getReductionAmount()?

Not sure, doesn't seem that it would clarify much, also because of reduction types being amount and percentage

sarjon · 2019-05-15T08:35:50Z

src/Core/Domain/CatalogPriceRule/Command/AddCatalogPriceRuleCommand.php

+        $groupId,
+        $fromQuantity,
+        $reduction,
+        $shopId = null,


Is shop association really optional?

sarjon · 2019-05-15T08:38:19Z

src/Core/Domain/CatalogPriceRule/Query/GetCatalogPriceRuleForEditing.php

+/**
+ * Provides data transfer object for editing CatalogPriceRule
+ */
+class GetCatalogPriceRuleForEditing


As discussed before, should we rename it to GetCatalogPriceRuleForEditForm? ping @matks

As discussed before, should we rename it to GetCatalogPriceRuleForEditForm? ping @matks

I guess you mean rename to 'GetCatalogPriceRuleForUpdating' ? or smth associated with update

No, I mean GetCatalogPriceRuleForEditForm.

I'm sorry I might have forgotten something here :/ why do you want to modify the naming ?

I'm not against it, I just want to understand 😅
And then we might need to write a convention and modify it everywhere

sarjon · 2019-05-15T08:39:02Z

src/Core/Domain/CatalogPriceRule/QueryResult/EditableCatalogPriceRule.php

+/**
+ * Provides data for editing CatalogPriceRule
+ */
+class EditableCatalogPriceRule


I think this should be called CatalogPriceRuleForEditForm. ping @matks

As I see all the other handlers are named like Get[name]ForEditing

sarjon · 2019-05-15T09:29:10Z

src/Core/Form/IdentifiableObject/DataHandler/CatalogPriceRuleFormDataHandler.php

+    /**
+     * @param CommandBusInterface $commandBus
+     * @param $isMultishopEnabled
+     * @param $contextShopId


Missing type hints.

zuk3975 · 2019-05-15T12:33:56Z

@matks, ready for review

zuk3975 · 2019-05-15T12:56:20Z

src/Adapter/CatalogPriceRule/CommandHandler/AddCatalogPriceRuleHandler.php

+    /**
+     * {@inheritdoc}
+     */
+    public function handle(AddCatalogPriceRuleCommand $command)


@matks, I found this smartyCache cleaning unnecessary, but I'm not really sure, wdyt?

PrestaShop/controllers/admin/AdminSpecificPriceRuleController.php

Line 376 in 0181a42

Tools::clearSmartyCache();

You can read about that here : #13627 (comment)

In fact cache need to be cleared in order to update price in all existing smarty cache but doing here is not really good as you can read on my report.

Very interesting, thanks @Matt75 !
@zuk3975 I suggest we remove it for now but create a dedicated issue for that.

I can imagine 3 solutions for this issue (there might be more):

display a warning message after a catalog price rule has been created "eyh ! you created a rule, you probably want to clear the cache to make sure FO display is right !" with a link/button to perform the clear (additionnaly: using an ajax request so we dont freeze the screen ❤️)

put a timer to clear cache 1 minute after last catalog price rule modification in order to avoid to perform 1 clear by rule created

allow merchant to control whether he wants to clear the cache manually or automatically with a boolean configuration value

created a reminder issue for that #14761

src/Core/Domain/CatalogPriceRule/Command/AddCatalogPriceRuleCommand.php

LouiseBonnard · 2019-05-21T10:00:14Z

src/PrestaShopBundle/Resources/views/Admin/Sell/Catalog/CatalogPriceRule/Blocks/form.html.twig

+      }) }}
+
+      {{ ps.form_group_row(catalogPriceRuleForm.reduction_type, {}, {
+        'label': 'Reduction Type'|trans({}, 'Admin.Catalog.Feature'),


Hey, please write Reduction type without the second capital letter, thank you.

src/PrestaShopBundle/Resources/views/Admin/Sell/Catalog/CatalogPriceRule/Blocks/form.html.twig

zuk3975 · 2019-06-13T10:21:48Z

src/PrestaShopBundle/Form/Admin/Sell/CatalogPriceRule/CatalogPriceRuleType.php

+        ;
+
+        if ($this->isMultishopEnabled) {
+            $builder->add('id_shop', ChoiceType::class, [


@matks, I see that shop field is not in the specs doc. Is it missed by mistake (I guess, yes, otherwise we don't know which shop to target), or it really shouldn't be there?

ping @marionf who will have the answer 😄

ping @marionf again 😄
The specifications doc does mention the "shop" input for multistore, is that expected or a small mistake ?

sarjon · 2019-06-17T13:31:38Z

src/Core/ConstraintValidator/Constraints/Reduction.php

+use Symfony\Component\Validator\Constraint;
+
+/**
+ * Provides reduction validation by reduction type


Constraint for validating reduction?

sarjon · 2019-06-17T13:34:31Z

src/Core/ConstraintValidator/ReductionValidator.php

+            $message = $constraint->invalidPercentageMessage;
+        }
+
+        if (DomainConstraintException::INVALID_REDUCTION_TYPE === $exceptionCode) {


I think you could merge it into elseif.

sarjon · 2019-06-17T13:42:36Z

src/Core/ConstraintValidator/Constraints/Reduction.php

+
+    public $invalidAmountMessage = 'Reduction value is invalid.';
+
+    public $invalidPercentageMessage = 'Reduction value is invalid.';


Why do you need 3 different properties for messages? Aren't 2 enough:
$invalidTypeMessage - when reduction type is invalid (for example type is not percent nor amount)
$invalidValueMessage - when reduction value is invalid (for example value is 110 when percent is type)

But the cap of 100% should be applied only for percentage value, else its constrained to be >= 0. So the error messages differs a bit

I updated the default messages in constraints, now it should make sense

sarjon · 2019-06-17T13:43:25Z

src/Core/Domain/CatalogPriceRule/Command/AddCatalogPriceRuleCommand.php

+        $fromQuantity,
+        $reductionType,
+        $reductionValue,
+        $shopId,


Can it only be created for single shop?

according to legacy - yes, according to current specs - i don't see shop selection, but waiting for @matks response if it's not missed by mistake.

sarjon · 2019-06-17T13:49:08Z

src/Core/Domain/CatalogPriceRule/Query/GetCatalogPriceRuleForEditing.php

+/**
+ * Provides data transfer object for editing CatalogPriceRule
+ */
+class GetCatalogPriceRuleForEditing


No, I mean GetCatalogPriceRuleForEditForm.

sarjon · 2019-06-17T13:50:28Z

src/Core/Domain/CatalogPriceRule/QueryResult/EditableCatalogPriceRule.php

+        $to,
+        $reductionType,
+        $includeTax,
+        $reduction


Do you think Reduction VO could be used instead?

sarjon · 2019-06-17T13:50:41Z

src/Core/Domain/CatalogPriceRule/QueryResult/EditableCatalogPriceRule.php

+     * @param float $reduction
+     */
+    public function __construct(
+        $catalogPriceRuleId,


I think you can use VO here.

sarjon · 2019-06-17T13:54:24Z

src/Core/Form/ChoiceProvider/PriceReductionTypeChoiceProvider.php

+    {
+        return [
+            $this->translator->trans('Amount', [], 'Admin.Global') => 'amount',
+            $this->translator->trans('Percentage', [], 'Admin.Global') => 'percentage',


How about using constants for amount and percentage from VO?

sarjon · 2019-06-17T13:56:53Z

src/PrestaShopBundle/Form/Admin/Sell/CatalogPriceRule/CatalogPriceRuleType.php

+            ])
+            ->add('reduction', ReductionType::class, [
+                'constraints' => [
+                    new ReductionConstraint($this->getReductionMessages()),


I think Constraint suffix is not needed.

matks · 2019-07-18T16:09:37Z

admin-dev/themes/new-theme/js/app/utils/datepicker.js

+ *   <input type="text" class="form-control"
+ *     data-format="YYYY-MM-DD HH:mm:ss"     // provide data-format attr in case you need custom format
+ *   />
+ * </div>
 */
 const init = function initDatePickers() {


We need a more accurate name for this class, because we might need multiple date-pickers extensions. Some with YYYY-MM-DD, some with only YYYY-MM, some side-by-side, some other displays ... so we need to name them accurately in order to avoid confusion and pick the one we need

Actually I would like to wait for #14748 this to be solved, as I guess it will modify this js file.

#14748 has been fixed by #14914 😉

matks · 2019-07-18T16:12:10Z

admin-dev/themes/new-theme/js/pages/catalog-price-rule/form/index.js

+const $ = window.$;
+
+$(() => {
+  new PriceFieldAvailabilityHandler('#catalog_price_rule_leave_initial_price', '#catalog_price_rule_price');


Please create a dedicated JS file to contain these selectors, like here:
https://github.com/PrestaShop/PrestaShop/blob/develop/admin-dev/themes/new-theme/js/pages/employee/employee-form-map.js
And use it like this
https://github.com/PrestaShop/PrestaShop/blob/develop/admin-dev/themes/new-theme/js/pages/employee/EmployeeForm.js

This will help our friends from the QA team to target them and build E2E tests 😉

matks · 2019-07-18T16:17:08Z

src/Adapter/CatalogPriceRule/CommandHandler/AddCatalogPriceRuleHandler.php

+    /**
+     * {@inheritdoc}
+     */
+    public function handle(AddCatalogPriceRuleCommand $command)


Very interesting, thanks @Matt75 !
@zuk3975 I suggest we remove it for now but create a dedicated issue for that.

I can imagine 3 solutions for this issue (there might be more):

display a warning message after a catalog price rule has been created "eyh ! you created a rule, you probably want to clear the cache to make sure FO display is right !" with a link/button to perform the clear (additionnaly: using an ajax request so we dont freeze the screen ❤️)

put a timer to clear cache 1 minute after last catalog price rule modification in order to avoid to perform 1 clear by rule created

allow merchant to control whether he wants to clear the cache manually or automatically with a boolean configuration value

matks · 2019-07-18T16:17:59Z

src/Adapter/CatalogPriceRule/CommandHandler/EditCatalogPriceRuleHandler.php

+     *
+     * @throws PrestaShopException
+     */
+    private function createSpecificPriceRuleFromCommand(EditCatalogPriceRuleCommand $command)


It's not exactly create right ? 😄

Fetch ? Get ? Populate ? Hydrate ?

matks · 2019-07-18T16:18:19Z

src/Adapter/CatalogPriceRule/CommandHandler/AddCatalogPriceRuleHandler.php

+                    sprintf('Failed to create specific price rule')
+                );
+            }
+            $specificPriceRule->deleteConditions();


👍 nice operations split

matks · 2019-07-19T07:20:33Z

src/Adapter/CatalogPriceRule/CommandHandler/AddCatalogPriceRuleHandler.php

+     */
+    private function createSpecificPriceRuleFromCommand(AddCatalogPriceRuleCommand $command)
+    {
+        $specificPriceRule = new SpecificPriceRule();


Must be boring to write these fields, but it's definitely very readable and maintanable 👍

matks · 2019-07-19T07:21:11Z

src/Adapter/CatalogPriceRule/CommandHandler/EditCatalogPriceRuleHandler.php

+                    sprintf('Failed to update specific price rule with id %s', $specificPriceRule->id)
+                );
+            }
+            $specificPriceRule->deleteConditions();


So we need to call this everytime we edit it ?

At least its how its done in legacy, but this should be checked more in-depth on separate PR of condition groups. Added a reminder here #10549 (comment)

matks · 2019-07-19T07:21:36Z

src/Adapter/CatalogPriceRule/CommandHandler/EditCatalogPriceRuleHandler.php

+            $specificPriceRule->reduction_tax = $command->isTaxIncluded();
+        }
+        if (null !== $command->getReduction()) {
+            $specificPriceRule->reduction_type = $command->getReduction()->getType();


Interesting 🤔

matks · 2019-07-19T07:21:54Z

src/Core/Domain/CatalogPriceRule/Command/AddCatalogPriceRuleCommand.php

+    private $fromQuantity;
+
+    /**
+     * @var Reduction


This is a good idea 👍

matks · 2019-07-19T07:29:46Z

src/Core/ConstraintValidator/ReductionValidator.php

+        }
+
+        $this->context->buildViolation($message, $params)
+            ->setTranslationDomain('Admin.Notifications.Error')


Can you check it works (check with 2 languages) ? I believe @mickaelandrieu told me once we could not use Symfony validator because there was only 1 translation catalog available.

You are right, it is not working 😞

matks · 2019-07-19T07:31:01Z

src/Core/ConstraintValidator/ReductionValidator.php

+        }
+
+        try {
+            new Reduction($value['type'], $value['value']);


So you're using validation checks in Reduction that throw DomainConstraintExceptions and catch them in order to write the right error message and avoid breaking the flow ..?

Euh ... 🤔it works but it hijacks the standard workflow of these validation checks.

I've never seen this way of validating an object 😅 it might feel weird, but maybe it's right.
Need more opinion, ping @PierreRambaud @jolelievre @eternoendless @mickaelandrieu

Look weird to use a constructor to validate data 🤔
ping @eternoendless

I agree with @PierreRambaud, please move the validation logic outside of Reduction constructor 😉

@matks although I agree that it's not the most convenient way to validate data, but it works.

We could of course duplicate validation that is inside Reduction constructor, but we can't move it out. Do you have anything else on your mind? :)

matks · 2019-07-19T07:31:30Z

src/Core/Domain/CatalogPriceRule/Command/AddCatalogPriceRuleCommand.php

+    /**
+     * @return Reduction
+     */
+    public function getReduction(): Reduction


php7 💪
I ❤️ that !

matks · 2019-07-19T07:34:03Z

src/Core/Domain/CatalogPriceRule/Command/AddCatalogPriceRuleCommand.php

+    {
+        try {
+            return new DateTime($dateTime);
+        } catch (Exception $e) {


Are you sure every Exception thrown from previous line are because of bad format 😄?

As the phpdoc says, yes.

If time contains an invalid date/time format, then an exception is now thrown. Previously an error was emitted

indeed, exception should be thrown only due to wrong format 😲 . Imo, the current message looks clear anyway

matks · 2019-07-19T07:37:09Z

src/Core/Domain/CatalogPriceRule/Command/EditCatalogPriceRuleCommand.php

+    /**
+     * @var float|null
+     */
+    private $price;


Maybe we should start using Number from https://github.com/PrestaShop/decimal here to carry the data

Sure, it'll get casted to float when the data is thrown back in the legacy
But at least it'll be the right data structure in the migrated part of the code

Wdyt ?

matks · 2019-07-19T07:40:37Z

src/Core/Domain/CatalogPriceRule/Query/GetCatalogPriceRuleForEditing.php

+/**
+ * Provides data transfer object for editing CatalogPriceRule
+ */
+class GetCatalogPriceRuleForEditing


I'm sorry I might have forgotten something here :/ why do you want to modify the naming ?

I'm not against it, I just want to understand 😅
And then we might need to write a convention and modify it everywhere

matks · 2019-07-19T07:41:28Z

src/Core/Domain/CatalogPriceRule/Exception/UpdateCatalogPriceRuleException.php

+/**
+ * Thrown when unable to update catalog price rule
+ */
+class UpdateCatalogPriceRuleException extends CatalogPriceRuleException


CannotUpdateCatalogPriceRuleException ? FailureToUpdateCatalogPriceRuleException ?

I thought the exception suffix should already indicate that something failed

matks · 2019-07-19T07:42:40Z

src/Core/Domain/CatalogPriceRule/QueryResult/EditableCatalogPriceRule.php

+/**
+ * Provides data for editing CatalogPriceRule
+ */
+class EditableCatalogPriceRule


matks · 2019-07-19T07:45:59Z

src/Core/Domain/ValueObject/Reduction.php

+     */
+    private function assertIsAllowedType(string $type)
+    {
+        if ($type !== self::TYPE_AMOUNT && $type !== self::TYPE_PERCENTAGE) {


If you use an in_array(), it will be easier to add new types later 😉

matks · 2019-07-19T07:56:03Z

src/PrestaShopBundle/Form/Admin/Sell/CatalogPriceRule/CatalogPriceRuleType.php

+        ;
+
+        if ($this->isMultishopEnabled) {
+            $builder->add('id_shop', ChoiceType::class, [


ping @marionf who will have the answer 😄

matks · 2019-07-19T08:02:44Z

src/PrestaShopBundle/Resources/config/routing/admin/sell/catalog/catalog_price_rule.yml

+  path: /
+  methods: [GET]
+  defaults:
+    _controller: 'PrestaShopBundle:Admin\Sell\Catalog\CatalogPriceRule:create'


Not create I think 😄

sarjon · 2019-08-05T07:12:50Z

@zuk3975 did you address all the comments from @matks review?

… DateTime usage

colinegin · 2019-11-13T14:32:44Z

Hello,

FYI i've just created a new issue to change some wording on this page.
Here is the issue : #16402

zuk3975 requested a review from a team as a code owner May 8, 2019 15:27

prestonBot added develop Branch Refactoring Type: Refactoring Waiting for wording Status: action required, waiting for wording labels May 8, 2019

matks added the migration symfony migration project label May 9, 2019

matks mentioned this pull request May 10, 2019

Migrate "Catalog > Discounts > Catalog price rules" page #10549

Open

36 tasks

PierreRambaud reviewed May 13, 2019

View reviewed changes

sarjon reviewed May 15, 2019

View reviewed changes

zuk3975 commented May 15, 2019

View reviewed changes

PierreRambaud reviewed May 15, 2019

View reviewed changes

src/Core/Domain/CatalogPriceRule/Command/AddCatalogPriceRuleCommand.php Outdated Show resolved Hide resolved

zuk3975 changed the title ~~[WIP] Migrate Sell > Catalog > Catalog price rule create/edit action~~ Migrate Sell > Catalog > Catalog price rule create/edit action May 17, 2019

LouiseBonnard reviewed May 21, 2019

View reviewed changes

LouiseBonnard added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels May 21, 2019

zuk3975 mentioned this pull request May 27, 2019

Allow Hour in specific Price #8571

Closed

zuk3975 changed the title ~~Migrate Sell > Catalog > Catalog price rule create/edit action~~ [WIP] Migrate Sell > Catalog > Catalog price rule create/edit action Jun 6, 2019

prestonBot added the Waiting for wording Status: action required, waiting for wording label Jun 6, 2019

matks changed the title ~~[WIP] Migrate Sell > Catalog > Catalog price rule create/edit action~~ Migrate Sell > Catalog > Catalog price rule create/edit action Jun 7, 2019

LouiseBonnard removed the Waiting for wording Status: action required, waiting for wording label Jun 10, 2019

zuk3975 commented Jun 13, 2019

View reviewed changes

sarjon reviewed Jun 17, 2019

View reviewed changes

zuk3975 mentioned this pull request Jul 18, 2019

Migrate Sell > Catalog > Discounts > Catalog Price Rules list #13584

Merged

zuk3975 changed the title ~~Migrate Sell > Catalog > Catalog price rule create/edit action~~ [WIP] Migrate Sell > Catalog > Catalog price rule create/edit action Jul 18, 2019

matks reviewed Jul 18, 2019

View reviewed changes

matks reviewed Jul 19, 2019

View reviewed changes

zuk3975 force-pushed the m/catalog-price-rules-edit branch from 09e1b75 to 0da87c9 Compare July 19, 2019 07:46

matks requested changes Jul 19, 2019

View reviewed changes

zuk3975 mentioned this pull request Jul 19, 2019

Implement FO cache clearing after catalog price rule creation/update #14761

Open

zuk3975 added 18 commits November 11, 2019 10:48

Catch generic Exception. Handle dateTime null.

8572a66

Adds js selectors mapping in form

ed0e83e

adds index.js file that belong sto previous commit

fa84321

Adds todo in routes, modifies translation wording in form

c5b415d

Modify DateTime Error message

579988b

Minor optimization in VO

fbaeb49

Implements Decimal/Numeric to price and reduction

70952b2

Minor code cleaning in reduction VO

a61330a

Adds quantity field constraint

bbb0538

Fixes todo for DateTime::Null constant

7749d89

Fix typo in const

4cf935e

Removes unused types, added on rebasing

193a486

Extract Reduction validation from constructor in Constraint validator

847fe2c

Clarify exception names

1db8083

Some code optimization

c29aa51

Set error path for ReductionConstraint

50b9c77

Adds validation of date range

ffd12e6

Fix wrong array element selction in handler. Add namespace for native…

1b300df

… DateTime usage

zuk3975 force-pushed the m/catalog-price-rules-edit branch from b0926c9 to 1b300df Compare November 11, 2019 08:49

rebuilds assets

82de15e

jolelievre approved these changes Nov 12, 2019

View reviewed changes

jolelievre removed the Waiting for rebase Status: action required, waiting for rebase label Nov 12, 2019

sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 12, 2019

Progi1984 merged commit ef9ab64 into PrestaShop:develop Nov 12, 2019

LouiseBonnard mentioned this pull request Nov 13, 2019

[Catalog price rule page] Replace "reduction" with "discount" #16402

Closed

matks mentioned this pull request Apr 17, 2020

Migrate "Catalog > Discounts > Catalog price rules > Add new / edit catalog price rule" page #10548

Open

29 tasks

zuk3975 deleted the m/catalog-price-rules-edit branch April 20, 2020 07:39

hibatallahAouadni mentioned this pull request Nov 18, 2020

AdminStockManagementController clears smarty cache every time it's loaded. #21944

Closed


		public $invalidAmountMessage = 'Reduction value is invalid.';

		public $invalidPercentageMessage = 'Reduction value is invalid.';

Migrate Sell > Catalog > Catalog price rule create/edit action #13716

Migrate Sell > Catalog > Catalog price rule create/edit action #13716

Conversation

zuk3975 commented May 8, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarjon May 15, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zuk3975 commented May 15, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zuk3975 Jul 19, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zuk3975 Jul 19, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarjon commented Aug 5, 2019

colinegin commented Nov 13, 2019

zuk3975 commented May 8, 2019 •

edited

sarjon May 15, 2019 •

edited

zuk3975 Jul 19, 2019 •

edited

zuk3975 Jul 19, 2019 •

edited